Hi Peter,

On Sun, 6 Aug 2006 11:41:21 +0200
"Peter J. Holzer" <[EMAIL PROTECTED]> wrote:

> While changing the spamassassin plugin to allow per-user
> configuration, I noticed that Qpsmtpd::DSN produces messages like:
> 
> 552 spamassassin score 15.6/10 (#5.7.1)
> 
> According to RFC 2034 the extended status code should be included
> just after the normal status code, like this:
> 
> 552 5.7.1 spamassassin score 15.6/10
> 
> The format with the parentheses and the hash does look vaguely
> familiar, though. Is this described in some other RFC or is it
> something some popular MTA does (In our outgoing logs I see that Yahoo
> and messagelabs.com produce such messages).
I got the idea for this module after playing a bit with an old qmail
installation. It gave the "Sorry, this domain is not listed in my
rcpthosts (#5.7.1)" message (message from memory, I don't have any qmail
installation at hand now). That's why the message is structured like it
is now. 
Patching the module to match RFC 2034 messages would be easy, i.e. 

--- DSN.pm.orig 2006-01-25 09:00:35.000000000 +0100
+++ DSN.pm      2006-08-06 15:22:17.000000000 +0200
@@ -154,7 +154,7 @@
     if (defined $reason) {
         $msg = $reason;
     }
-    return ($return, "$msg (#$class.$subject.$detail)");
+    return ($return, "$class.$subject.$detail $msg");
 }


Since we're not supporting the ENHANCEDSTATUSCODES keyword from RFC
2034 (and probably won't do in future, because we'd have to rewrite
lots of stuff in core and nearly all modules) I don't see why we should
change it.

        Hanno

Reply via email to