On 2006-08-06 15:45:36 +0200, Hanno Hecker wrote: > On Sun, 6 Aug 2006 11:41:21 +0200 > "Peter J. Holzer" <[EMAIL PROTECTED]> wrote: > > I noticed that Qpsmtpd::DSN produces messages like: > > > > 552 spamassassin score 15.6/10 (#5.7.1) > > > > According to RFC 2034 the extended status code should be included > > just after the normal status code, like this: > > > > 552 5.7.1 spamassassin score 15.6/10 > > > > The format with the parentheses and the hash does look vaguely > > familiar, though.
> I got the idea for this module after playing a bit with an old qmail
> installation. It gave the "Sorry, this domain is not listed in my
> rcpthosts (#5.7.1)" message (message from memory, I don't have any qmail
> installation at hand now).
Ah, I thought I had seen this with qmail, but one qmail site I know of
didn't seem to return such messages.
> Patching the module to match RFC 2034 messages would be easy, i.e.
>
> --- DSN.pm.orig 2006-01-25 09:00:35.000000000 +0100
> +++ DSN.pm 2006-08-06 15:22:17.000000000 +0200
> @@ -154,7 +154,7 @@
> if (defined $reason) {
> $msg = $reason;
> }
> - return ($return, "$msg (#$class.$subject.$detail)");
> + return ($return, "$class.$subject.$detail $msg");
> }
Not quite as easy as the enhanced status code must be repeated on each
line of a multi-line response. But still fairly easy.
> Since we're not supporting the ENHANCEDSTATUSCODES keyword from RFC
> 2034 (and probably won't do in future, because we'd have to rewrite
> lots of stuff in core and nearly all modules) I don't see why we should
> change it.
I'm aware of that. RFC 2034 mandates that "these codes must appear in
*all* 2xx, 4xx, and 5xx response lines other than initial greeting and any
response to HELO or EHLO." so we really shouldn't advertise
ENHANCEDSTATUSCODES in the EHLO message unless we either rewrite all
error message or automatically produce enhanced status codes. I
suggested a way to do the latter not too long ago. I'll check if it is
feasible.
But even if we aren't compliant to RFC 2034, I'd prefer to be produce
messages which comply to it sometimes than never.
hp
--
_ | Peter J. Holzer | > Wieso sollte man etwas erfinden was nicht
|_|_) | Sysadmin WSR | > ist?
| | | [EMAIL PROTECTED] | Was sonst wäre der Sinn des Erfindens?
__/ | http://www.hjp.at/ | -- P. Einstein u. V. Gringmuth in desd
pgpJyNWIdLc8E.pgp
Description: PGP signature
