On Sat, 2007-05-05 at 11:31 +0200, Johan Almqvist wrote: > On Fri, May 04, 2007 at 08:48:08PM +0200, Peter J. Holzer wrote: > > 1) LANG should be set globally to a value, so that each method and <snip> > > 2) A function which modifies LANG should restore the original value <snip> > Wouldn't it be a more stable design if the main code checked that LANG > still is set to C or undef after each plugin hook call? I don't think > that generates a lot of overhead.
I don't think the code should be doing anything with LANG at all. The problem started because the value for the 'smtpd' user was something other than 'C'. Peter says "for now" here: http://www.nntp.perl.org/group/perl.qpsmtpd/2007/05/msg6626.html I'll unset LANG and LC_* in the init.d-script for now, but such places should probably be identified and fixed individually. and the rules he has set out are for plugins where someone finds a case where. for some reason, they feel the need to manipulate LANG settings. Robert Spier said: http://www.nntp.perl.org/group/perl.qpsmtpd/2007/05/msg6622.html Either way, we wouldn't be localizing anything in the headers - SMTP (or convention) provides a format for those things. If we localize anything, it'll be plain text strings that are irrelevant to the protocol. > -Johan -- --gh
