On May 9, 2009, at 19:21, Charlie Brady wrote:

If the assertion that the existing old simple version is useless is correct, is there much justification for keeping the old simple version?

This is really a namespace issue, I think. Should "check_spamhelo" belong to an old simple ineffective plugin, or a newer, and presumably more useful, one?

As much as it sucks to lose the old simple plugins for examples, I think I could go for replacing it with a newer one.

My only nitpicks on Marks code (on scanning the code for the patch) are

1) don't have the 'tld regexp' be configurable

2) the documentation needs updating (and/or a default config should be supplied)

3) The NOIPHC thing is a little dubious -- it won't work with forkserver etc anyway, so if we need a whitelisting mechanism, that isn't it.


 - ask

--
http://develooper.com/ - http://askask.com/


Reply via email to