Hi,
Please, hide private symbols by default on all platforms.
It's a good style for a library, because it allows to avoid symbol
conflicts.
See the applied patch.
Regards,
Alexander
--- a/Qt4Qt5/Qsci/qsciglobal.h
+++ b/Qt4Qt5/Qsci/qsciglobal.h
@@ -32,18 +32,12 @@
#define QSCINTILLA_VERSION_STR "2.9.1"
-// Under Windows, define QSCINTILLA_MAKE_DLL to create a Scintilla DLL, or
-// define QSCINTILLA_DLL to link against a Scintilla DLL, or define neither
-// to either build or link against a static Scintilla library.
-#if defined(Q_OS_WIN)
-
#if defined(QSCINTILLA_DLL)
-#define QSCINTILLA_EXPORT __declspec(dllimport)
+#define QSCINTILLA_EXPORT Q_DECL_IMPORT
#elif defined(QSCINTILLA_MAKE_DLL)
-#define QSCINTILLA_EXPORT __declspec(dllexport)
+#define QSCINTILLA_EXPORT Q_DECL_EXPORT
#endif
-#endif
#if !defined(QSCINTILLA_EXPORT)
#define QSCINTILLA_EXPORT
--- a/Qt4Qt5/qscintilla.pro
+++ b/Qt4Qt5/qscintilla.pro
@@ -24,7 +24,7 @@
TEMPLATE = lib
TARGET = qscintilla2
-CONFIG += qt warn_off release thread exceptions debug
+CONFIG += qt warn_off release thread exceptions debug hide_symbols
INCLUDEPATH += . ../include ../lexlib ../src
!CONFIG(staticlib) {
_______________________________________________
QScintilla mailing list
[email protected]
https://www.riverbankcomputing.com/mailman/listinfo/qscintilla
