On Thursday 15 September 2011 19:12:56 ext David Faure wrote: > Well, apart from the "too many details about the spec" the API in qmime.git > is mostly good, I like QMimeDatabase. > > But the code is mostly about parsing XML files... > > Well, anyway. I'll let you and Wolf-Michael debate about which API is > chosen for inclusion into Qt, and only then I'll implement the > shared-mime-info backend into the chosen repository. Better not do it > twice.
I took a look at QMimeDatabase, and the first thing that I stumbled over is the addMimeTypes() method. It creates a dependency on freedesktop.org.xml or some edited version of it. In my opinion, this will not work on every platform out there (particulary the smaller ones). The test cases then seem to use the findByName(), findByData() and findByFile() methods. They look straightforward to me. The code about user-modified MIME types I don't find really necessary in the API. Also, can we leave all mutable methods out of the interface, and let the individual platform deal with the question on how the data gets into that database? That would match the discussion we had about my proposal, too. _______________________________________________ Qt5-feedback mailing list [email protected] http://lists.qt.nokia.com/mailman/listinfo/qt5-feedback
