Hi David, On Wednesday 21 September 2011 08:27:52 ext David Faure wrote:
> > > Well, apart from the "too many details about the spec" the API in > > > qmime.git is mostly good, I like QMimeDatabase. > > > > > > But the code is mostly about parsing XML files... > > > > > > Well, anyway. I'll let you and Wolf-Michael debate about which API is > > > chosen for inclusion into Qt, and only then I'll implement the > > > shared-mime-info backend into the chosen repository. Better not do it > > > twice. > > > > I took a look at QMimeDatabase, and the first thing that I stumbled over > > is the addMimeTypes() method. It creates a dependency on > > freedesktop.org.xml or some edited version of it. In my opinion, this > > will not work on every platform out there (particulary the smaller > > ones). The test cases then seem to use the findByName(), findByData() > > and findByFile() methods. They look straightforward to me. The code > > about user-modified MIME types I don't find really necessary in the API. > > Also, can we leave all mutable methods out of the interface, and let the > > individual platform deal with the question on how the data gets into > > that database? That would match the discussion we had about my proposal, > > too. > > I completely agree. > > BTW I'm working on fixing the tests in shared-mime-info itself, because > xdgmime is missing a few features. I have done some extensive code cleanup in the "wolf" branch of the qmime repository. It has reached the point where I would agree to it. If Иван is ok with this too, then I'd suggest to use this as a starting point for the next activities: - Merge my changes into qmime/master. - Иван could work on necessary changes for qtcreator without which he said qtcreator will not compile any more. - David could implement the shared-mime-info backend as suggested in the qmime repository. - I could add a QML wrapper based on my previous work. I still have one question about one of QMimeType's properties, genericIconName. I'd prefer to change that property into returning the actual path to the icon file to be more portable. What is the proper way to get an icon file name from the generic icon name? Also, why do the glob patterns for *.tar.gz return *.tar.gz *.tgz *.taz when suffixes only returns tgz and taz? Finally, who are the people with actual stakes who should be on the list of reviewers? _______________________________________________ Qt5-feedback mailing list Qt5-feedback@qt.nokia.com http://lists.qt.nokia.com/mailman/listinfo/qt5-feedback
