On Dec 15, 2014, at 5:22 AM, Feng Lu <[email protected]> wrote: > (1) u_short instance > > The instance ID is defined as an unsigned short value. It seems enough > for now, while I don't know whether it would be proper in the future > or for some special reason. > > Is it more better to use u_int32_t? > > Or at least, I suggest to add a type definition in zebra.h like: > > typedef u_int32_t inst_t; > > to avoid changing the code everywhere if we would need to change the > type.
+1. Also simplifies issue #8. > (7) > /* Configuration filename and directory. */ > -char config_default[] = SYSCONFDIR OSPF_DEFAULT_CONFIG; > +char config_default[100]; > > > /* Process ID saved for use by init system */ > -const char *pid_file = PATH_OSPFD_PID; > +char pid_file[100]; > > + char vty_path[100]; > > There should be a better way to define the string length than a hard- > coding value 100. For example: > > char pid_file[2 * sizeof (PATH_OSPFD_PID)] = PATH_OSPFD_PID; Use PATH_MAX? /a _______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
