On Wed, 27 May 2015 08:49:02 +0200 David Lamparter <[email protected]> wrote:
> On Tue, May 26, 2015 at 10:27:54PM +0100, Paul Jakma wrote: > > On Tue, 26 May 2015, David Lamparter wrote: > > > The simple choice is using it as-is :) > > > > It's not that hard, I'll send something tomorrow. > > What'd really help is a if_gethwaddr() function in lib/if.c, because > in isisd/isis_circuit.c:602, zebra/interface.c:757, zebra/rtadv.c:318 > we each have pretty similar code... Well, why it should be a function? We should have struct interface contain always the same datatypes (regardless of OS / configure checks). Now it is not so with the hw addr. That way all those places can just memcpy(). Of course adding functions makes sense if we want to make the core structs opaque. Is that something we want to do also? _______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
