On Wed, 27 May 2015 17:21:52 +0100 (BST)
Paul Jakma <[email protected]> wrote:

> So something like the below to go before your patch (probably a good
> few of the types could be removed - I removed the ones that seemed
> obviously defunct to me (EcoNet, Chaos, the Linux Prism driver type),
> probably a good few more, if anyone knows - e.g. PRONet, ARCNet,
> MetriCom ??).

Right.

I would add IP6GRE (ARPHRD_IP6GRE) which is "GRE over IPv6". I'll
probably support that later on when the basics are done properly.

> commit 6dbe5e7304cd6329b562bf052083fa2a867b8c98
> Author: Paul Jakma <[email protected]>
> Date:   Wed May 27 16:28:11 2015 +0100
>
>[snip]
> diff --git a/lib/if.h b/lib/if.h
> index e1f28e1..0a34a10 100644
> --- a/lib/if.h
> +++ b/lib/if.h
> @@ -112,7 +112,9 @@ struct interface
>       struct sockaddr_storage sdl_storage;
>     };
>   #else
> -  unsigned short hw_type;
> +  /* Link-layer information */
> +  unsigned short ll_type;
> +#define hw_type ll_type

I'd definitely avoid this. If changing to ll_type, let's update all
source code accordingly; it's only used in few places. I'll update my
commit then too.


Thanks,
Timo

_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to