isisd: Attached-bit in LSP header http://patchwork.quagga.net/patch/1287/ https://lists.quagga.net/pipermail/quagga-dev/2015-July/012913.html
Resubmitted patch with modifications as V2. isisd: Fix overload-bit http://patchwork.quagga.net/patch/1289/ https://lists.quagga.net/pipermail/quagga-dev/2015-July/012920.html Unaddressed comment from Donald? Need to abandon the patch. Overload-bit does not require a fix. Thanks, Amritha -----Original Message----- From: Paul Jakma [mailto:[email protected]] Sent: Friday, August 21, 2015 10:12 AM To: Quagga Devel Cc: Nambiar, Amritha; [email protected]; [email protected]; [email protected]; [email protected]; Baptiste Daroussin; Jafar Al-Gharaibeh; Kaloyan Kovachev Subject: patch reviews, 2 Hi, I've gone through some more of the patchwork and bugzilla backlog. http://git.savannah.gnu.org/cgit/quagga.git/log/?h=volatile/patch-tracking/2/proposed/ff More to catch up on, but might as well checkpoint here. Mostly pimd and some isisd stuff. Sanity checks (e.g. right version of the patch), Acks/Nacks, etc., would be really useful. Not gotten to NHRP. Longer comments ideally should go on a patch-specific Quagga-dev thread, e.g. reply in the original thread of the patch - if it exists and you have it handy. Please note: subject lines really should start with "<daemon or subsystem>:", e.g. "bgpd:", "lib:", "build:", etc. These allow those preparing releases to more quickly created topic-sorted short-release notes. pimd fatal asserts: Other patch to be sent by Donald or Everton? http://patchwork.quagga.net/patch/1261 https://lists.quagga.net/pipermail/quagga-dev/2015-June/012775.html Not in the cumulus/pimd_fixings tree? See also 1262, 1263, pimd: add support for configuring multicast static routes http://patchwork.quagga.net/patch/1260/ https://lists.quagga.net/pipermail/quagga-dev/2015-June/012773.html queued. pimd assert when no route to source from a new igmp join http://patchwork.quagga.net/patch/1264/ https://lists.quagga.net/pipermail/quagga-dev/2015-June/012786.html queued. Quagga, BGP feature Best External http://patchwork.quagga.net/patch/1265/ http://patchwork.quagga.net/patch/1277/ https://lists.quagga.net/pipermail/quagga-dev/2015-June/012822.html https://lists.quagga.net/pipermail/quagga-dev/2015-June/012867.html Needs a proper commit message, documentation and some tidying, at a minimum. Some compile warnings added - BGP_SHOW_SCODE_HEADER extended with another %s but uses didn't have extra VTY_NEWLINE added. Fixed. PIMD: DR election happens on every hello received http://patchwork.quagga.net/patch/1267/ supersed by: http://patchwork.quagga.net/patch/1268/ v2, (1/2) https://lists.quagga.net/pipermail/quagga-dev/2015-June/012824.html Some discussion on this on and off. Status unclear. ? picked from cumulus/pimd_fixings pimd: Fix first DR Election (v2, 2/2) https://lists.quagga.net/pipermail/quagga-dev/2015-June/012838.html http://patchwork.quagga.net/patch/1269/ superseded: http://patchwork.quagga.net/patch/1272/ (v3) https://lists.quagga.net/pipermail/quagga-dev/2015-June/012845.html picked from cumulus/pimd_fixings Add ability to set DR Priority for an interface http://patchwork.quagga.net/patch/1270/ https://lists.quagga.net/pipermail/quagga-dev/2015-June/012839.html picked from cumulus/pimd_fixings PIMD: Stop DR election on every hello received http://patchwork.quagga.net/patch/1273/ https://lists.quagga.net/pipermail/quagga-dev/2015-June/012846.html picked from cumulus/pimd_fixings See also https://github.com/CumulusNetworks/quagga/tree/pimd_fixings - presumably that's up to date with above? I've cherry-picked the missing commits from that. rare bgp crash http://patchwork.quagga.net/patch/1278/ http://patchwork.quagga.net/patch/1279/ http://patchwork.quagga.net/patch/1281/ https://lists.quagga.net/pipermail/quagga-dev/2015-June/012875.html 1279 seems to be the agreed fix? What's the correct commit? Change ioctl call failure from vty_out to zlog_warn http://patchwork.quagga.net/patch/1284/ https://lists.quagga.net/pipermail/quagga-dev/2015-July/012910.html Commit message format? Ensure new generation_id is different from previous http://patchwork.quagga.net/patch/1285/ https://lists.quagga.net/pipermail/quagga-dev/2015-July/012911.html Commit message format? PIMD: Create ability to modify hello and hold timers per interface http://patchwork.quagga.net/patch/1290/ https://lists.quagga.net/pipermail/quagga-dev/2015-July/012921.html Outstanding comment from Everton? isisd: Add new adjacency to LSP neighbor list http://patchwork.quagga.net/patch/1286/ https://lists.quagga.net/pipermail/quagga-dev/2015-July/012912.html Unanswered comment from Donald? isisd: Attached-bit in LSP header http://patchwork.quagga.net/patch/1287/ https://lists.quagga.net/pipermail/quagga-dev/2015-July/012913.html isisd: Fix overload-bit http://patchwork.quagga.net/patch/1289/ https://lists.quagga.net/pipermail/quagga-dev/2015-July/012920.html Unaddressed comment from Donald? Add support for FreeBSD distinct kernel FIBs https://bugzilla.quagga.net/show_bug.cgi?id=839 VRF integration? Should this be integrated with the VRF ID already being kept somehow? build: Remove the old PIC/PIE patch, let libtool sort it out http://patchwork.quagga.net/patch/1317/ https://lists.quagga.net/pipermail/quagga-dev/2015-August/013028.html Carried over from previous round: zebra/bgpd realms https://lists.quagga.net/pipermail/quagga-dev/2015-July/012901.html I havn't pulled the updated patches over yet. My concern with this is its Linux specific, adding a Linux specific ID to (struct peer) - I wonder if maybe it could be done by allowing an existing BGP attribute to be sent as the realm on Linux (e.g. community?) regards, -- Paul Jakma [email protected] @pjakma Key ID: 64A2FF6A Fortune: American by birth; Texan by the grace of God. _______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
