On Wed, 2015-09-30 at 21:46 -0400, Donald Sharp wrote:
> Joakim -
>
> Before I clean up the patch any further, I believe something like this is
> being proposed, is this correct?
Something like that although flags should be mandatory, even if is is zero.
However, there was a discussion about having zebra autodetect ONLINK instead?
Jocke
> sharpd@Robot:~/q7$ git diff
> diff --git a/zebra/zebra_rib.c b/zebra/zebra_rib.c
> index e9623ee..e3447af 100644
> --- a/zebra/zebra_rib.c
> +++ b/zebra/zebra_rib.c
> @@ -198,13 +198,15 @@ nexthops_free (struct nexthop *nexthop)
> }
>
> struct nexthop *
> -nexthop_ifindex_add (struct rib *rib, unsigned int ifindex)
> +nexthop_ifindex_add (struct rib *rib, unsigned int ifindex, unsigned char
> flags)
> {
> struct nexthop *nexthop;
>
> nexthop = XCALLOC (MTYPE_NEXTHOP, sizeof (struct nexthop));
> nexthop->type = NEXTHOP_TYPE_IFINDEX;
> nexthop->ifindex = ifindex;
> + if (flags)
> + SET_FLAG(nexthop->flags, NEXTHOP_FLAG_ONLINK);
>
> nexthop_add (rib, nexthop);
>
> diff --git a/zebra/zserv.c b/zebra/zserv.c
> index 8ae0cfa..ec982e0 100644
> --- a/zebra/zserv.c
> +++ b/zebra/zserv.c
> @@ -870,7 +870,8 @@ zread_ipv4_add (struct zserv *client, u_short length,
> vrf_id_t vrf_id)
> {
> case ZEBRA_NEXTHOP_IFINDEX:
> ifindex = stream_getl (s);
> - nexthop_ifindex_add (rib, ifindex);
> + flags = stream_getc (s);
> + nexthop_ifindex_add (rib, ifindex, flags);
> break;
> case ZEBRA_NEXTHOP_IFNAME:
> ifname_len = stream_getc (s);
>
>
>
>
> On Wed, Sep 30, 2015 at 2:38 PM, Joakim Tjernlund
> <[email protected]> wrote:
> > On Tue, 2015-09-29 at 16:29 -0400, Donald Sharp wrote:
> > > This series of patches adds the ability to ospf to have
> > > unnumbered interfaces.
> > >
> > > James Li (2):
> > > zebra: Add a new zebra message type ZEBRA_MESSAGE_ONLINK.
> >
> > This (or similar) impl. has already been discussed once before and there
> > is a better way, search for "quagga" and "ONLINK" in Google.
> >
> > > ospfd: Add unnumbered interface support
> >
> > Borrowing the loopback IP too restricted. Just use whatever IP address the
> > IF has.
> > Also, I need to set OSPF on an IF basis, see
> >
> > http://git.savannah.gnu.org/cgit/quagga.git/commit/?h=volatile/paul/unnumbered&id=01817cf848330b6791e8ea9
> > 5314b4707825a4bfa
> > for an example.
> >
> > Jocke
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
