On Mon, 4 Jan 2016 21:05:28 -0500
Donald Sharp <[email protected]> wrote:

> Timo -
> 
> Sorry for the delay in looking at this.  Xmas and all that :)
> 
> netlink_route_multipath -> Does this need the 4th parameter?  Why not
> just depend on the prefix?
> kernel_rtm_ipv4 & _ipv6 -> Same comment family is never used.
> 
> kernel_route_rib adds a HAVE_IPV6.  This is not needed anymore.
> 
> Looks good otherwise.

All valid points. I think they are legacy from the time I
wrote this - as well as from the old code.

I'll do the clean up of old cruft while at this - and resend after
updating the whole series. There was still one compile issue in the
last patch on *BSD.

Thanks,
Timo 

_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to