On 6/15/2016 11:38 AM, David Lamparter wrote: > On Tue, Jun 14, 2016 at 10:03:41AM -0400, Lou Berger wrote: >> Eak -- the branch doesn't compile with -std=c99 . > Standard for Quagga is currently "-std=gnu99" as seen in configure.ac > line ~140; there seems to be a bug somewhere that the flag isn't > correctly applied?
Why use -std=gnu99? Before these changes quagga, e.g., the current release, compiled fine without the flag. Lou > > -David > >> On 6/14/2016 9:47 AM, Lou Berger wrote: >>> Paul, >>> >>> Great to see this published. Is there a quagga convention WRT C99? >>> >>> I see the following when compiling proposed/8 >>> >>> if.c:1151: error: ?for? loop initial declarations are only allowed in >>> C99 mode >>> if.c:1151: note: use option -std=c99 or -std=gnu99 to compile your code >>> zclient.c:903: error: ?for? loop initial declarations are only allowed >>> in C99 mode >>> zclient.c:903: note: use option -std=c99 or -std=gnu99 to compile your code >>> interface.c:2505: error: ?for? loop initial declarations are only >>> allowed in C99 mode >>> interface.c:2505: note: use option -std=c99 or -std=gnu99 to compile >>> your code >>> >>> Lou >>> >>> On 6/14/2016 9:02 AM, Paul Jakma wrote: >>>> Hi, >>>> >>>> Took a bit longer, but the proposed patches are up in: >>>> >>>> http://git.savannah.gnu.org/cgit/quagga.git/log/?h=volatile/patch-tracking/8/proposed/patchwork >>>> http://git.savannah.gnu.org/cgit/quagga.git/log/?h=volatile/patch-tracking/8/proposed/donald-take-3 >>>> >>>> I've done some initial prioritising, so the 'restricted node' patch, >>>> 'sockaddr_dl' and table cmd are at the end, as there were already some >>>> comments on those. >>>> >>>> Note: I've had a good few conflicts on 'install_element' lines, due to >>>> various patches adding/removing commands with the restricted node and >>>> 'auto-install view commands into enable' patches. I didn't look too >>>> closely as to whether I resolved them correctly. >>>> >>>> Still to do is linearise these 2 heads together. >>>> >>>> regards, >>> >>> _______________________________________________ >>> Quagga-dev mailing list >>> [email protected] >>> https://lists.quagga.net/mailman/listinfo/quagga-dev >>> >> >> >> _______________________________________________ >> Quagga-dev mailing list >> [email protected] >> https://lists.quagga.net/mailman/listinfo/quagga-dev _______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
