I haven’t seen any fixes yet, but the Round 8 breaks on several points
on my CI system:
As a side note, I’m a little bit disappointed that all were all marked
as failed by my CI
system, not tested (series of patches are sometimes missed as finding
complete series isn’t perfect)
or never submitted to patchwork or the list
We could have all avoided this…
1) DejaGNU testcli:
[…]
Running ./libzebra.tests/testcli.exp ...
FAIL: testcli
[…]
—> The offending commit for this is 0dbe0d2 (“lib: Consolidate
VIEW_NODE to be ENABLE_NODE as well”)
This is Patchwork #1856
Originally failed CI test:
https://ci1.netdef.org/browse/QUAGGA-QPWORK-251
2) DejaGNU testbgpmpattr IPv6-default: IPV6 MP Reach, global nexthop, 2
NLRIs + default -- testbgpmpattr aborted!
[…]
Running ./bgpd.tests/testbgpmpath.exp ...
Running ./bgpd.tests/testbgpmpattr.exp ...
failed: testbgpmpattr IPv6-default: IPV6 MP Reach, global nexthop, 2
NLRIs + default -- testbgpmpattr aborted!
[…]
—> The offending commit for this is 82655af (“bgpd, zebra: Use next
hop tracking for connected routes too”)
This is Patchwork #1640
Was never tested by my CI system (it is part of a series of 89 patches
which is a challenge for the automated
patchwork testing setup on my CI system)
3) missing htonf on OpenBSD / NetBSD 6/7 / FreeBSD 8/9/10 / OmniOS:
[…]
make all-am
CC network.lo
network.c: In function 'htonf':
network.c:109:2: error: #error "Please supply htonf implementation for
this platform"
#error "Please supply htonf implementation for this platform"
^
network.c:111:1: warning: control reaches end of non-void function
[-Wreturn-type]
}
^
*** Error code 1
[…]
The offending commit for this is f8e536e (“lib: consolidate
ntohf/htonf from ospfd/isisd TE to lib/network”)
This is was never seen in Patchwork. No idea where this patch came
from…
4) bootstrap.sh fails on Ubuntu 16.04
./bootstrap.sh
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
libtoolize: 'AC_PROG_RANLIB' is rendered obsolete by 'LT_INIT'
configure.ac:97: error: possibly undefined macro: AC_MSG_RESULT
If this token and others are legitimate, please use
m4_pattern_allow.
See the Autoconf documentation.
autoreconf: /usr/bin/autoconf failed with exit status: 1
—> The offending commit for this is 09d4631 (“qpb: Add support for
protobuf”)
(Small note: Running “bootstrap.sh” a 2nd time will work.)
This is Patchwork 1884 which somehow was missed in my CI system as well.
(My CI
system never detected this as a complete series of patches, so no run
was triggered)
Would appreciate if someone can spend a few cycles on fixing this BEFORE
pushing more
commits into this branch as these are multiple teststoppers.
The list is potentially not complete - as the tests fail at various
stages on all platforms
based on these problems. There could be more issues later on…
- Martin Winter
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
