On 08/31/2012 01:28 PM, Robert Kukura wrote: > On 08/31/2012 09:43 AM, Dan Wendlandt wrote: >> On Fri, Aug 31, 2012 at 6:12 AM, Robert Kukura <[email protected]> wrote: >>> On 08/31/2012 01:29 AM, Dan Wendlandt wrote: >>>> for your next commit message, please bug "bug #1037341" in the commit >>>> message. this will automatically move the bug on LP to 'fix >>>> committed'. >>> >>> I should have added that to the previous patch's commit message. >>> >>> Also, https://bugs.launchpad.net/quantum/+bug/1035492 can be closed. >>> >>> I still think I should file a separate bug specifically related to the >>> attribute names change. >>> >>> Any issue with putting all three in this patch's commit message? >> >> sure, though it would be good to comment in the commit message that >> this was the last patch in a series of patches that fulfilled those >> bugs. This is useful just so people don't think it was just that >> final patch that did all of the work for this bug. > > The patch is ready for review.
I'd appreciate if we could get https://review.openstack.org/#/c/12271/ (the provider:vlan_id->provider:segmentation_id rename) reviewed and hopefully approved today. This is mostly very straightforward renaming and switching to using constants. Salvatore has already gone through it once, and I've responded to his comments. I'm filing at least half a dozen bugs against the linuxbridge and openvswitch plugins today, some of which Gary and I would like to make progress fixing over the weekend. At least some of these fixes are likely to touch the same lines of code as this review, so getting this approved will save work. I'd also like to update the wiki on configuring openvswitch with the new names before any of it gets pulled into documentation. Thanks, -Bob -- Mailing list: https://launchpad.net/~quantum-core Post to : [email protected] Unsubscribe : https://launchpad.net/~quantum-core More help : https://help.launchpad.net/ListHelp
