I agree, though I'm guessing there is some reason garyk added them (other than the thrill of committing code to openstack :P). Perhaps we just need to be more clear about why we are depending on various common modules. The commit message is one place we could put this, though such info may become stale over time.
dan On Wed, Nov 7, 2012 at 9:10 AM, Mark McClain <[email protected]>wrote: > All- > > Playing catch-up this morning. Today we had three reviews that were > merged. > > https://review.openstack.org/#/c/15551/ > https://review.openstack.org/#/c/15556/ > https://review.openstack.org/#/c/15557/ > > While updates to OS-common are nice, why are we adding code that actually > is not used within Quantum? The reason I'm asking is that 15551 could not > stand on its own and would have failed any unit tests had it actually been > used within Quantum. > > I'm fine with updating existing OS-common modules, but it seems like new > modules should actually have a Quantum use case when they are added. > (Similar to adding need project dependencies). > > Thoughts? > > mark > -- > Mailing list: https://launchpad.net/~quantum-core > Post to : [email protected] > Unsubscribe : https://launchpad.net/~quantum-core > More help : https://help.launchpad.net/ListHelp > -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira, Inc: www.nicira.com twitter: danwendlandt ~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- Mailing list: https://launchpad.net/~quantum-core Post to : [email protected] Unsubscribe : https://launchpad.net/~quantum-core More help : https://help.launchpad.net/ListHelp
