-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 07/20/2017 09:08 AM, Andrew Morgan wrote: > On 07/20/2017 12:03 AM, Andrew Morgan wrote: >> On 07/19/2017 11:56 PM, Patrik Hagara wrote: >>> On 07/20/2017 07:42 AM, Andrew Morgan wrote: >>>> I'm currently trying to work out a bug where inotify_watch >>>> calls will fail around the 8000th folder that's created or >>>> moved in. I'm assuming this probably has to do with a limit >>>> coded somewhere so I'm looking out for that. >>> >>> Sounds like fs.inotify.max_user_watches sysctl [1] is the >>> culprit (set to 8192 by default). >>> >>> >>> Cheers, Patrik >>> >>> >>> [1] >>> https://unix.stackexchange.com/questions/13751/kernel-inotify-watch-limi >>> t-reached >>> >> >> That was it, thanks Patrik! >> >> So should we just up this from the daemon or from within the >> template? Is there any reason not to I wonder? > > Ah just checked the stackoverflow source, seems as if memory is the > only concern. We definitely don't want the daemon to be unable to > correctly mark files, so either we set it appropriately high and/or > warn the user when we've reached the limit.
You're welcome. :) Yes, simply printing a warning is what I've seen programs like Dropbox and minidlna do. If your daemon is running with root privileges, it could modify the sysctl itself (but it's an ugly hack). If not, adding the sysctl call to /rw/config/rc.local would work on a per-VM basis (either manually by user or automatically by daemon). Setting the limit globally in a template would not waste any extra kernel memory in AppVMs that don't make use of inotify watches (ie. don't run the daemon) and would be the cleanest option IMO. And it could even be done via a post-install scriptlet of your new package. Cheers, Patrik -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZcFpXAAoJEFwecd8DH5rlmM4QAI6PGHnpaG/MR6UkEd02152N WXCeODX6JjxfxTzAf64ll3eitdATJT+g3yU0E4XEj+qa8DzfPgMwDFrnOPXMQuK6 NIEqBib4yoy6OgQ7e9i2ns8k4qy5dVM8547hnAVVQsD3p4ruJi/AOyKeDFZJlreq n2nubxm15LviMNw6mIq5ktYUY1+Xr0Zi4hziwcrezgwmyfuYs9D2OSCyQWLjUQFz WdByy1vYJYEU0y9BdgoRGo4l+At4DuBNClamgvTOFtuD4U7psdu1SQcpMR3wGHdm Tm23fvMEfsvsQwjckJS3dq9QWJY6pKcHaOCfnNYzM0dD7bHhKfAvL8xUapgSFc+3 cWBiwyv1Z0OxZV9Obw/wBeSGzIgrboZH0nMNZecoeYc79+V39NV4zZ2iGJNECr1/ DDUExU7jPwfmexce2rGwUCm02CCl6+EvScpaG2kyU6YgjkpiA5AZ7F4uxm5yRw3N gDZ1cVeOvv/pyUAm0igDVQyGNFBLbQWOf0hyLz7soP1SNOA+LUKK2IGcc1osONQ0 QgwhJHgYxkBPPzVEzcEIKWOEAgQkfNUi7SI/Uqstq3gUApw+Yz9PDHXUWyOJnqsj PpVVSp4GCLSxMQRvcFZZJmY/FuWXND0fXjMU2eVSS37Lw5qopd79/K9lAp/1ZKWl VzLx5sgHu2myl4K+KwOJ =dZQs -----END PGP SIGNATURE----- -- You received this message because you are subscribed to the Google Groups "qubes-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/qubes-devel/c382b8bc-b2a5-6d31-c0dd-9cf922a0e8ff%40gmail.com. For more options, visit https://groups.google.com/d/optout.
0x031F9AE5.asc
Description: application/pgp-keys
0x031F9AE5.asc.sig
Description: PGP signature
