On 07/20/2017 12:23 AM, Patrik Hagara wrote: > On 07/20/2017 09:08 AM, Andrew Morgan wrote: >> On 07/20/2017 12:03 AM, Andrew Morgan wrote: >>> On 07/19/2017 11:56 PM, Patrik Hagara wrote: >>>> On 07/20/2017 07:42 AM, Andrew Morgan wrote: >>>>> I'm currently trying to work out a bug where inotify_watch >>>>> calls will fail around the 8000th folder that's created or >>>>> moved in. I'm assuming this probably has to do with a limit >>>>> coded somewhere so I'm looking out for that. >>>> >>>> Sounds like fs.inotify.max_user_watches sysctl [1] is the >>>> culprit (set to 8192 by default). >>>> >>>> >>>> Cheers, Patrik >>>> >>>> >>>> [1] >>>> > https://unix.stackexchange.com/questions/13751/kernel-inotify-watch-limi >>>> t-reached >>>> >>> >>> That was it, thanks Patrik! >>> >>> So should we just up this from the daemon or from within the >>> template? Is there any reason not to I wonder? > >> Ah just checked the stackoverflow source, seems as if memory is the >> only concern. We definitely don't want the daemon to be unable to >> correctly mark files, so either we set it appropriately high and/or >> warn the user when we've reached the limit. > > You're welcome. :) > > Yes, simply printing a warning is what I've seen programs like Dropbox > and minidlna do. > > If your daemon is running with root privileges, it could modify the > sysctl itself (but it's an ugly hack). If not, adding the sysctl call > to /rw/config/rc.local would work on a per-VM basis (either manually > by user or automatically by daemon). Setting the limit globally in a > template would not waste any extra kernel memory in AppVMs that don't > make use of inotify watches (ie. don't run the daemon) and would be > the cleanest option IMO. And it could even be done via a post-install > scriptlet of your new package. > > > Cheers, > Patrik >
Fair point! I'll add it to the Makefile for now. Andrew Morgan -- You received this message because you are subscribed to the Google Groups "qubes-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to qubes-devel+unsubscr...@googlegroups.com. To post to this group, send email to qubes-devel@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/qubes-devel/okpmca%24c9t%241%40blaine.gmane.org. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: OpenPGP digital signature
