-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 23-05-19 14:52:57, Marek Marczykowski-Górecki wrote: > Hi, > > Those look very useful! > > I have one comment to qubes-policy-edit-terminal: when using > policy_get() (or policy_include_get()), you get a policy content and a > token. Use that token in policy_replace() call to detect race conditions > (when something else changes the same policy file in the meantime).
Will add the token argument and let the exceptions handle the rest. Just one thing, the name "qubes-policy-editor-terminal" is non-ideal. I just added "terminal" to the name because "qubes-policy-editor" was taken by the GUI application implemented with: https://github.com/QubesOS/qubes-desktop-linux-manager/pull/143 Can Qubes keep the standard of using "*-gui" for GUI applications? Some use, some doesn't. In short, I am asking for the Qubes Team to rename the current GUI app to qubes-policy-editor-gui, so the one provided by this thread can be named qubes-policy-editor. If the answer is no to the rename action, I will just add the token argument. > > I am doing vim-qrexec, will notice when ready for review, it requires > > the qubes-policy-lint for linting the policies from within Vim. So I > > will wait for a resolution of this topic. > > > > Repository: https://codeberg.org/ben.grande.b/qubes-tools > > Would you like to submit those to the core-qrexec repository? Yes. Also take a look vim-qrexec to see if it is possible to be included in qubes-core-qrexec: https://codeberg.org/ben.grande.b/vim-qrexec It is not complicated, but it is extensive and written in VimScript. It can be used in DomUs and Dom0, but the lint tool can only be run in Dom0. If you prefer, I can start another thread to better explain it. - -- Benjamin Grande -----BEGIN PGP SIGNATURE----- iNUEARYKAH0WIQRklnEdsUUe50UmvUUbcxS/DMyWhwUCZG3m8l8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0NjQ5 NjcxMURCMTQ1MUVFNzQ1MjZCRDQ1MUI3MzE0QkYwQ0NDOTY4NwAKCRAbcxS/DMyW h9HlAQCFIso4eOAQ9ynOf/RNYZEjOxcgfDU4Qa68kJxoR4GKDgD9FuUcOdpnFWux CkcL740GdvTa0oNILS0hZxyFysx6cwQ= =J7JP -----END PGP SIGNATURE----- -- You received this message because you are subscribed to the Google Groups "qubes-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to qubes-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/qubes-devel/ZG3m80pZHGNTBoa%2B%40personal-mutt.
