-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On Mon, Aug 21, 2023 at 08:49:21PM +0000, Ben Grande wrote: > On 23-08-20 14:01:53, Marek Marczykowski-Górecki wrote: > > On Fri, Aug 11, 2023 at 02:17:00PM +0000, Ben Grande wrote: > > > Status: > > > - Missing change 'qubes-policy-editor' to 'qubes-policy-editor-gui'; > > > > https://github.com/QubesOS/qubes-desktop-linux-manager/pull/172 > > > > You can rename to plain qubes-policy-editor now. > > > > While at it, please add new files to packaging > > (debian/qubes-core-qrexec.install, rpm_spec/qubes-qrexec.spec.in). Right > > now packages fail to build. > > > > > - Missing review of the last commit quoted above. > > > > The last commit looks fine. > > Added files to packaging.
You missed files in python lib dir (qrexec/tools/qubes_policy_...) in the spec file. Generally, the preferred workflow is through github pull requests - we have CI configured there to catch issues like this. If you really hate github, sending patches like this is okay too, but since it requires a bit more manual work on my side (including pushing them to CI manually...), it also takes some more time to get them merged. > I believe in this case it is easier for you to pull from the 'lint' > branch instead of applying the patches manually as multiple commits were > done. If that is not the case, I will post the patches. > > https://codeberg.org/ben.grande.b/qubes-core-qrexec/src/branch/lint Yes, that's fine (but see above). - -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab -----BEGIN PGP SIGNATURE----- iQEyBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmTowEAACgkQ24/THMrX 1yyQowf47CY7VTxIizI1fk8v5c58RIltQ9YFF7eRbhB87TaiH3GEhbQQfoWmv41k 4rvbWWP9QuN7tVoTCAfadB10BH0cI5H5AmdvhFzF1iMwlaEv7726pnX6k+qbhAM0 Nlvh9KbfczjxPspjq80ETc38pHX2lO6x6G7jlYubNl7E96mPhJwCxK5QD0EETvMo lfyIXIGX0uMHBry+SinhAY4WGGWoTKB+BA6/iJrfiooCJHKcJNVkI3HjpmnvpM3l 35ZRzBLCYYqQi4CqSkPwDhXGgWkTxdp/b0JzVyeyvcjkhAVXcD8ba9t0JRm68QAd T+69fv45P9OHvu5ZtywYEhPssSFP =5ea7 -----END PGP SIGNATURE----- -- You received this message because you are subscribed to the Google Groups "qubes-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to qubes-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/qubes-devel/ZOjAQDbDKSxAuAjs%40mail-itl.
