Updates:
Owner: [email protected]
Comment #13 on issue 1132 by [email protected]: Add "Subject of" block to
context menu for authority records
http://code.google.com/p/qubit-toolkit/issues/detail?id=1132
Wu, I've prepared a patch based on yours:
http://www.sevein.com/tmp/issue1132.patch
This patch fixes some small problems found in your code, most of them just
simple coding style issues:
- Remove unnecessary blank lines.
- Remove the <div /> tag wrapping the header <h3 />.
- In foreach iterators, we call $item to the variable which is assigned for
each loop.
- Remove isset() check for $subjectInfoObjects in favour of blank.js
behavior. You only have to assign the class "section" to this block and it
will be hidden automatically if it is empty.
- The header ("Subject of") shouldn't be repeated for each item in the
array, we add as many <li /> items as we need.
I also recommend you to read our coding standard:
http://qubit-toolkit.org/wiki/index.php?title=Coding_standard
Does this look right to you? Thank you in advance, we appreciate your
effort!
--
You received this message because you are subscribed to the Google Groups "Qubit
Toolkit Issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/qubit-issues?hl=en.
