--- On Mon, 10/12/12, Martin Maechler <maech...@stat.math.ethz.ch> wrote:
> > --- On Sun, 9/12/12, Dirk > Eddelbuettel <e...@debian.org> > wrote: > > > On 9 December 2012 at 18:17, Hin-Tak Leung wrote: > > | Noticed a problem for a while - tests/testit.Rd, > > tests/ver20.Rd are removed on "make clean" > unintentionally. > > | > > | This seems to come from a change in > tests/Makefile.in, which adds the line: > > | -@rm -f *.tar.gz *.Rd back in May 2012. > > | > > | ----------- > > | commit c4d70254e7b7f9d7ed17faecfb3097195d852ddc > > | Author: ripley > <ripley@00db46b3-68df-0310-9c12-caf00c1e9a41> > > | Date: Sun May 27 09:04:41 2012 +0000 > > | > > | fix some issues seen by examining > no-segfaults.Rout > > | > > [..... dropped > ..... embarrassing / amusing distraction on svn/git ..... > ..... started by the OP, not by Dirk ! > ] That comment is a bit childish, don't you think? > > That said ..a small bug was introduced back in > May ..... > > Yes, you are right. > BTW: The reason that nobody (from R core, probably not many > people otherwise) has found/mentioned this bug before is not > the > use of svn, but the fact that it is much more convenient > (and > hence somewhat recommended) to build R outside of its > source > directory, and in that case the two *.Rd files that belong > to > ./tests/ are not removed (from the *build* directory's > ./tests/) "more convenient" is a subjective matter. As I mentioned in my original post, I have a few local modifications which are continually re-applied ("rebase"d, but I shall not be drawn into arguing about matters of personal preference again) - therefore it is more convenient to build on top. Since we are on the topic of locally-continually applied modifications, I reported another issue about 40 days ago, that reccent R trunk now treat revision as numeric, so 'unknown' in the topic level Makefile.in should be changed accordingly to 0 or some number. Here is the diff - one of the "locally-continually applied modifications" I am talking about: --- a/Makefile.in +++ b/Makefile.in @@ -94,7 +94,7 @@ svnonly: @if test ! -f "$(srcdir)/doc/FAQ" || test -f non-tarball ; then \ (cd doc/manual && $(MAKE) front-matter html-non-svn) ; \ touch non-tarball ; \ - (cd $(srcdir); LC_ALL=C TZ=GMT svn info || $(ECHO) "Revision: unknown") 2> /dev/null \ + (cd $(srcdir); LC_ALL=C TZ=GMT svn info || $(ECHO) "Revision: 0") 2> /dev/null \ | sed -n -e '/^Revision/p' -e '/^Last Changed Date/'p \ | cut -d' ' -f1,2,3,4 > SVN-REVISION-tmp ; \ $(SHELL) $(top_srcdir)/tools/move-if-change SVN-REVISION-tmp SVN-REVISION ; \ ______________________________________________ R-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-devel