Great feedback, thank you. I like all your suggestions. - Boolean arguments: great point, will do - MIME types: Yes, I should use/add a more complete extension→type mapping, though I probably will continue not to validate MIME types against the IANA list. (My somewhat erroneous note in the docs notwithstanding, it turns out having a non-IANA MIME type or a valid but mismatched type in an enclosure doesn’t actually cause feed validation errors.) - language-codes: yes this should be a value, not a procedure. Will change it. - Contract boundaries: yes! switching to contract-out is on my list - Removing dependencies: yes, I see the appeal. I’m really not eager to reimplement all the timezone handling and temporal comparison stuff in gregor, though.
Joel On Monday, October 25, 2021 at 6:36:30 PM UTC-5 Sage Gerard wrote: > Thank you for this!! > > Feedback > > - I like your podcast-specific entries > - The validation logic is refreshing to see > - Re: boolean arguments, I'd stick to keyword arguments and ask for > any/c, not boolean?, in contracts. That way forms like (and ... (member > ...)) won't bug users about a non-threatening contract violation, and it's > trivial to cast the value yourself. > - Unsure what licenses are compatible with Blue Oak. If you want more > licensing options re: IANA media type to extension mappings, here are some. > - MIT: https://github.com/mime-types/mime-types-data > - Apache 2.0 (From the horse's mouth): > https://svn.apache.org/repos/asf/httpd/httpd/trunk/docs/conf/mime.types > - CC-BY-SA: Scrape MDN's table using the console on > > https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types > > - I normally don't use functions like splitflap-version because I > can't assume that a package will define one. I'd use a program that > returns > a version of a given package. > - Why is language-codes a procedure? > - You have a lot of local contract boundaries, so values may get > checked more than necessary. > - Prefer example.com so you don't have to leak your URLs or make up > email addresses that actually go to an inbox. > - txexpr, gregor, and web-server dependencies don't look terribly > difficult to remove > > -- You received this message because you are subscribed to the Google Groups "Racket Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to racket-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/racket-users/cb2927c7-3d21-41c3-89c7-d6b73a9e53f9n%40googlegroups.com.
