What if the user types in:
<r:children:each> (forgets to close the tag)
<r:assets:link id="title" /> (uses title instead of id)
<r:snippet /> (doesn't specify the name)
Instead of the exceptions bubbling up to the top and just seeing a 500
error page, wouldn't it be better to catch those errors and insert the
error message directly into page content?
Joe
On Fri, Oct 17, 2008 at 3:44 PM, Manuel Meurer <[EMAIL PROTECTED]> wrote:
> >From radius.rb #284
>
> # Like method_missing for objects, but fired when a tag is undefined.
> # Override in your own Context to change what happens when a tag is
> # undefined. By default this method raises an UndefinedTagError.
> def tag_missing(name, attributes, &block)
> raise UndefinedTagError.new(name)
> end
>
> Guess it's just a preference thing.
> I like strong validation.
>
> Manuel
>
> On Fri, Oct 17, 2008 at 11:54 PM, Joe Van Dyk <[EMAIL PROTECTED]> wrote:
>> Makes sense -- why wouldn't that be that way by default?
>>
>> Joe
>>
>> On Fri, Oct 17, 2008 at 1:37 PM, Manuel Meurer <[EMAIL PROTECTED]> wrote:
>>> Change #28 in vendor/radiant/app/models/page_context.rb from
>>>
>>> raise StandardTags::TagError.new(e.message)
>>>
>>> to
>>>
>>> "Radius error: #{e.message}"
>>>
>>> Manuel
>>>
>>> On Fri, Oct 17, 2008 at 9:31 PM, Joe Van Dyk <[EMAIL PROTECTED]> wrote:
>>>> Err, sure: <r:asdf />
>>>>
>>>> On Fri, Oct 17, 2008 at 12:28 PM, Manuel Meurer <[EMAIL PROTECTED]> wrote:
>>>>> What exactly do you mean by "messes up a radiant tag"?
>>>>> Do you have an example?
>>>>>
>>>>> Manuel
>>>>>
>>>>> On Fri, Oct 17, 2008 at 7:00 PM, Joe Van Dyk <[EMAIL PROTECTED]> wrote:
>>>>>> Right now, when an editor messes up a radiant tag, a 500 page gets
>>>>>> rendered.
>>>>>>
>>>>>> Would it be possible to display the page content, except for the
>>>>>> radiant tag that had the error, and show the error message in place of
>>>>>> that tag?
>>>>>>
>>>>>> Joe
>>>>>> _______________________________________________
>>>>>> Radiant mailing list
>>>>>> Post: [email protected]
>>>>>> Search: http://radiantcms.org/mailing-list/search/
>>>>>> Site: http://lists.radiantcms.org/mailman/listinfo/radiant
>>>>>>
>>>>> _______________________________________________
>>>>> Radiant mailing list
>>>>> Post: [email protected]
>>>>> Search: http://radiantcms.org/mailing-list/search/
>>>>> Site: http://lists.radiantcms.org/mailman/listinfo/radiant
>>>>>
>>>> _______________________________________________
>>>> Radiant mailing list
>>>> Post: [email protected]
>>>> Search: http://radiantcms.org/mailing-list/search/
>>>> Site: http://lists.radiantcms.org/mailman/listinfo/radiant
>>>>
>>> _______________________________________________
>>> Radiant mailing list
>>> Post: [email protected]
>>> Search: http://radiantcms.org/mailing-list/search/
>>> Site: http://lists.radiantcms.org/mailman/listinfo/radiant
>>>
>> _______________________________________________
>> Radiant mailing list
>> Post: [email protected]
>> Search: http://radiantcms.org/mailing-list/search/
>> Site: http://lists.radiantcms.org/mailman/listinfo/radiant
>>
> _______________________________________________
> Radiant mailing list
> Post: [email protected]
> Search: http://radiantcms.org/mailing-list/search/
> Site: http://lists.radiantcms.org/mailman/listinfo/radiant
>
_______________________________________________
Radiant mailing list
Post: [email protected]
Search: http://radiantcms.org/mailing-list/search/
Site: http://lists.radiantcms.org/mailman/listinfo/radiant
