bluegaspode;525205 Wrote: > Marc, don't grumble, that's not true. > I'd say that 95% of your suggestions made it in the final code - and > the last 5% either didn't look important or you were not able to make > your point (when at least two people were listening) why some scenarios > would fail when these parts were done differently. Also some good things > came from Ben like caching the snooze-time from the server or > better/correct detection of failing audio. > > In the end Ben had a lot of testcases which he went through with the > final implementation and I think its not fair to say 'If you had taken > all of my code without questioning it wouldn't have happened' without > providing prove of it or providing a failing testcase. We are all > professional coders and should trust to make right decisions in the void > that is left without testcases. > > Now the work is to find out what the missing cases are and as we have > very good logging (and some user with problems) this shouldn't be too > difficult. Though it's not good that the fallback alarm is maybe firing > too often - its a good sign for reliablitiy (as it's better than a > missing alarm). > > I didn't have any alarm problem yet though I'm waking up to it every > morning - so I'm very interested to see some logs from the radio ! > > By the way - as logitechs focus has moved away from the alarm again I > would spent my time only in documenting the failing cases but personally > wouldn't look into the code again. Would be too depressing to wait for > someone caring for that in the end (did that once for 4 month, also see > thread starter, not again ;) )
I hear what you are saying, and you are right that Ben worked hard toward resolution of the alarm problems. Having said that, I disagree with some of what you stated above. Obviously, the alarm malfunctions I've witnessed in 7.4.2 are better than a missing alarm (no need for a specious argument)... I'll get the customary disclaimer out of the way [yet again] about how the underlying architecture is heavily flawed (the client/server aspect doesn't make sense in the context of how SC/MySB.com communicate with the Radio). The attempts I made to patch the existing architecture (it was clear a wholesale overhaul was not in the cards short term) for stability would indeed have resulted in a more stable alarm situation for 7.4.2. On that point we disagree. Enough has been changed such that I would need to largely begin anew in debugging/resolving. And for what...? Your good nature and useful input (along with that of others) served to greatly assist during the process. The environment here at the forums is compelling, as well (friendly, cooperative, etc.). However, there are indeed changes that were made to my modifications which were unwise. In the final analysis, alarms are still less stable than they should be... Marc -- Marc ------------------------------------------------------------------------ Marc's Profile: http://forums.slimdevices.com/member.php?userid=34776 View this thread: http://forums.slimdevices.com/showthread.php?t=75541 _______________________________________________ Radio mailing list [email protected] http://lists.slimdevices.com/mailman/listinfo/radio
