On 2/9/06, Michael Koziarski <[EMAIL PROTECTED]> wrote:
> * notests - For patches submitted without unittests
>
> These should also be marked XPATCH, because barring exceptional
> circumstances (or trivial fixes) we don't apply patches which don't
> include tests.
Going through and marking untested (or otherwise deficient) patches
XPATCH is an excellent idea - reducing the patch queue, and inviting
help in areas that need it.
I'm less keen on the 'notests' keyword, as I can't see what value it
adds to the XPATCH flag. A simple comment ('This patch looks
complete, but has no tests') would be enough for me. Some broader
designation that a patch is 'nearly there' might be more useful,
splitting patches that need loads of work from those that don't.
In the end though, it's not worth the time obsessing about. Let's try
out these ideas and see which ones stick.
Tom
--
email : tom at popdog.net
_______________________________________________
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-core
