pablobm left a comment (openstreetmap/openstreetmap-website#6424)
Right, that's all tests passing under the devcontainer, on my Mac and on CI.
Other environments yet to be tested.
I solved the issue with the cookies using `OSM.SERVER_PROTOCOL` as suggested. I
also did a refactor to DRY up the cookie handling. Another candidate for a
separate PR? Commit:
https://github.com/openstreetmap/openstreetmap-website/pull/6424/commits/60af1a16111da236fadeba9fa432408479ddc6fb
Still a few todo items to go through, plus the open questions.
Non-devcontainers tests are failing because I'm missing a cleanup: I didn't
want to commit too much time on that, just in case there are concerns about the
caveats.
If you have opinions, I'd love to hear them!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6424#issuecomment-3366166757
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6424/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
