@hlfan commented on this pull request.
I think the cookies clean up doesn't need that much of investigation ahead of
pulling it into its own PR.
> @@ -0,0 +1,17 @@
+name: devcontainer
+
+on:
+ - push
+ - pull_request
+
Could the superseded workflow cancellation work here too?
> @@ -27,6 +27,8 @@ OSM = {
end.to_json
%>,
+ COOKIES: Cookies.withAttributes({ path: "/", samesite: "lax", secure: <%=
(Settings.server_protocol == "https").to_json %> }),
Since this isn't a constant, I'd like it to be in lowercase.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6424#pullrequestreview-3301671767
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6424/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
