iandees left a comment (openstreetmap/openstreetmap-website#6448)
> On production, keys have a grey background and values a white background. On
> this PR it's an all-white background. (I'm not too bothered by this one, but
> I don't know what others think and whether they are aware).
I've been checking the history view but didn't think to check how these changes
affect the standard tag view. I'll look at that.
> On production, `wikidata` tags show the "barcode" icon to trigger an expand
> for more info. This is missing on the PR version.
See the discussion above about this – I decided that it would be too confusing
to have in this already-complex view and took it out to simplify. The
functionality exists in the standard tag view, though. I can try to add it back
in if we think it's important in the history view.
> the height whatever it is needs to be consistent with the non-history view
The rendered height of the tag rows is consistent. I'll take a look at what I
can do to get rid of the `!important` flags in the CSS, though.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6448#issuecomment-3486041705
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6448/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
