aNsHuL5217 left a comment (openstreetmap/openstreetmap-website#6571)
@pablobm Thank you for the detailed feedback!
I agree that the filled icons were visually too heavy for this context. I have
just pushed an update that switches all icons to their **outline ("no fill")
versions** (`bi-play`, `bi-stop`, `bi-chat-text`, `bi-question`). This should
make them blend in much better with the existing UI.
**Regarding the custom SVGs (`note.svg` and `query.svg`):**
The current context menu code is designed to use Bootstrap Icon CSS classes
(`bi-*`). To use the actual SVG files from `app/assets/images/`, I would likely
need to refactor `_createMenuItem` to support `<img>` tags or inline SVGs.
Would you prefer I attempt that refactor now, or are these outline icons a
close enough match to proceed for this PR?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6571#issuecomment-3606645335
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6571/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
