pablobm left a comment (openstreetmap/openstreetmap-website#6571)
Thank you for the update @aNsHuL5217. I think those icons look better now.
I am ok with the current result. I think this is a step in the right direction,
and the questions I raised are each complex and can take time to resolve so
they are better worked separately.
A couple of details:
- There are a number of changes that are unrelated to the substance of the PR.
I think you ran a linter and it changed more things than needed? Please remove
those.
- After that, can you please squash all the commits into a single one? I'm
realising this is not that clear in the contribution guidelines, we'll have to
update that.
Also a general piece of advice for contributions in any project: avoid using
`master` (or `main` or whatever a project uses) as your working branch, as that
makes it a bit more difficult to work with.
Finally, just out of curiosity if it's ok: how are you running the project in
your computer? Docker, rbenv, other? Just to have an idea of what people are
using, particularly those new to the project.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6571#issuecomment-3616553490
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6571/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
