fix #3611 ### Description
https://github.com/user-attachments/assets/726ba7a1-7d48-49ce-a5f2-6fd7f1c05f94 The interface now replicates https://github.com/Zverik/osmtags-editor, and some ideas, such as automatic generation of comments to changesets, are taken from my script. This is still a draft (it's fully functional, but the code could use some polishing here and there), so I invite you to test it. ## Do we need such an editor? Yes. See the [issue's](https://github.com/openstreetmap/openstreetmap-website/issues/3611) likes and [popularity](osmtags-editor) in the osmtags-editor community. ## Are we lowering the barrier to entry too much? We'll likely only find out about this once this feature is rolled out. Currently, the button only appears for authorized users. I see risks in making it easier to vandalize important objects (for example, those with Wikidata), which iD only allows editing in the tag editor. Well, I think if the situation gets out of control, we can check the `walkthrough_progress` value that the iD sets in Local Storage, or check the user's registration date on the server. I think we can find the optimal limitation. ## Maybe make it in the form of a table? Perhaps at least there won't be any unexpected = symbols for newbies. But I don't think this is a blocker to implementing the editor. ## created_by=? I'm waiting for your suggestions. Now I have put "Tags editor on osm.org" ## What's wrong with iD? He's slow and has a slow workflow for simple fixes. It's also terrible for mobile devices. ## comment=? The logic is as follows. If the next comment fits in 200 character sand contains no more than one _changed_ tag then: `Added key=value, key2=value2; Changed key3=prev_value→new_value; Removed key4=value from shop=yes name=OpenSpaceMarket` If the object does not have the following keys: `shop`, `building`, `amenity`, `man_made`, `highway`, `natural`, `aeroway`, `historic`, `railway`, `tourism`, `landuse`, `leisure` then it is substituted `node/12345` Otherwise, if this сomment does not fit into the limit, then simply use`Update tags of node/12345` ## Tests? It seems that writing unit tests is problematic in the current repository, but it is probably possible to write E2E tests. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6758 -- Commit Summary -- * Tags editor -- File Changes -- M app/assets/javascripts/index.js (1) A app/assets/javascripts/object_tags_editor.js (282) M app/views/elements/show.html.erb (4) M config/locales/en.yml (5) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6758.patch https://github.com/openstreetmap/openstreetmap-website/pull/6758.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6758 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/[email protected]>
_______________________________________________ rails-dev mailing list [email protected] https://lists.openstreetmap.org/listinfo/rails-dev
