@1ec5 commented on this pull request.


> @@ -8,7 +8,10 @@
   </div>
 <% else %>
   <div class="browse-section browse-node">
-    <%= render :partial => "common_details", :object => node %>
+      <%= render :partial => "common_details", :object => node, :locals => {
+            :tag_history => (is_history && node.latest_version? ? 
tags_with_version_info(node.current_node.node_tags, 
node.current_node.old_nodes) : node.tags),
+            :is_history => is_history && node.latest_version?

To a user, it might seem arbitrary that the version column only appears on the 
latest version. #4480 implemented a dedicated page for each version of the 
element. Blame information would be more at home in an element version page. 
Maybe it would even be feasible to extend this feature to any version of the 
element without quite as bad of a performance hit as similar functionality 
would have on the main element history page.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3535#pullrequestreview-3724650353
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/3535/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to