1ec5 left a comment (openstreetmap/openstreetmap-website#6266)
> The problem with this suggestion is that it's very expensive because it
> requires us to process the entire history of the object rather than just the
> current version. Not to mention that I'm not really sure where you would fit
> it in the user interface?
#3535 stuck it in a new column in the first section (newest revision) of the
element history page. The page already fetches all the versions, so that
wouldn’t necessarily add overhead in terms of fetching more database records
than necessary. At the time, we didn’t have element version pages yet. I think
nowadays the element version page would be a more logical home for this
information, but the performance hit would still be significant compared to
just fetching the current version.
Either way, I don’t see a reason why we’d need to proactively put blame
information in front of the user. Instead of saying upfront which version
introduced a given tag, each row of the table could have a button that
calculates and navigates to the relevant version on demand. By analogy, I use
GitHub’s “Show blame for this line” shortcut much more frequently than I
navigate to the full blame view directly. I assume it would be the same with
element history: normally a mapper wants to track down the origin of a specific
tag they’re already interested in. The only benefit to a more comprehensive
blame view would be to figure out which tags are newer and which are older, but
normally the element history view provides a more reliable idea of that anyways.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6266#issuecomment-3819944902
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/issues/6266/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
