@CommanderStorm commented on this pull request.
> + const attribution = new OSM.MapLibre.AttributionControl({
+ credit: layerConfig.credit,
+ includeReportLink: true
+ });
+ map.addControl(attribution, 'bottom-right');
- _update: function () {
- L.Control.Attribution.prototype._update.call(this);
+ const position = document.documentElement.dir === "rtl" ? "top-left" :
"top-right";
+ const navigationControl = new OSM.MapLibre.NavigationControl();
+ map.addControl(new OSM.MapLibre.CombinedControlGroup([navigationControl]),
position);
Is this RTL handling correct? (previously there was no RTL handling)
- attribution always on the right
- navigation on right for ltr and left for rtl
I am not an RTL expert, since germany is firmly LTR
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6804#pullrequestreview-3788564977
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6804/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
