@1ec5 commented on this pull request.


> +      reportLink.rel = "noopener noreferrer";
+      reportLink.className = "maplibregl-ctrl-attrib-report-link";
+      reportLink.textContent = OSM.i18n.t("javascripts.embed.report_problem");
+      attribHTML += reportLink.outerHTML + " | ";
+    }
+
+    const copyrightLink = document.createElement("a");
+    copyrightLink.href = "/copyright";
+    copyrightLink.textContent = 
OSM.i18n.t("javascripts.map.openstreetmap_contributors");
+
+    attribHTML += OSM.i18n.t("javascripts.map.copyright_text", {
+      copyright_link: copyrightLink.outerHTML
+    });
+
+    if (this._credit) {
+      attribHTML += this._credit.donate ? " ♥️ " : ". ";

Same reason as in 
https://github.com/openstreetmap/openstreetmap-website/pull/6601#discussion_r2604963172,
 probably premature optimization. If the attribution never appears without the 
trailing period, then we should fold the period into the attribution strings. 
But this should probably be a separate PR.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6804#discussion_r2797032479
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6804/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to