pablobm left a comment (openstreetmap/openstreetmap-website#6837)
Not at all! Just wanted to make sure that I don't go ahead but in the end it's
for nought, as neither of you had had time to review more thoroughly than that
initial comment (or so I interpreted) which is perfectly fine.
The "modern" style is the one I see in the Rails Guides at
https://guides.rubyonrails.org/action_mailer_basics.html. The examples there
all look like this:
```
UserMailer.with(user: @user).welcome_email.deliver_later
```
You are right however that the ActionMailer docs use the other style, which I
hadn't noticed. For example this:
```
NotifierMailer.welcome(User.first).deliver_now
```
So that's a bit annoying. Still I think new users are more likely to go by the
example in the guides, but the case for that is more tenuous now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6837#issuecomment-4000653785
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6837/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
