@gravitystorm requested changes on this pull request.
This should use resourceful naming. The controller should have one of the
specified action names (see
https://github.com/openstreetmap/openstreetmap-website/blob/94888241aef51eb3cd79300b5e7bd7954de8bedb/.rubocop.yml#L119-L129
), the route should be resourceful, and also the url used in the API should be
changed to match.
I agree that it should be a GET request, but you can't "get an allowed" -
"allowed" is not a noun.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7105#pullrequestreview-4336996224
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7105/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
