@hlfan commented on this pull request.


> @@ -24,6 +24,7 @@
     <div class="mb-3">
       <%= text_area_tag "text", "", :class => "form-control", :size => 
"40x10", :maxlength => "2000", :placeholder => t(".advice") %>
     </div>
+    <div id="new-note-error" class="alert alert-danger d-none"></div>

Does this have to be empty and filled with JS when not displayed anyway? Then a 
details/summary combination could be used to actually display the error without 
eslint shenanigans.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7132#pullrequestreview-4427112210
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/7132/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to