@hlfan commented on this pull request.
> @@ -141,20 +151,33 @@ OSM.NewNote = function (map) {
const location = newNoteMarker.getLatLng().wrap();
const text = content.find("textarea").val();
+ errorPanel = document.querySelector(".new-note-error");
+ errorPanel.classList.add("d-none");
I hate that this is the preferred and better way to do this here instead of one
with less scripting
```css
.new-note-error:has(.new-note-error__detail:empty) {display: none}
```
But in this project things like this should apparently be done with jQuery.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7132#pullrequestreview-4450547651
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7132/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
