@hlfan commented on this pull request.
> page_lang = Regexp.last_match(1)
title_section = Regexp.last_match(2)
else
+ return nil if lang.nil?
When no language is set in a secondary wikipedia key or value. Then we can't
know if the user is referring to a specific language wikipedia or maybe just
commenting.
I've also gone through some primary wikipedia tags without a language to find
many false positives with the assumed english one, which is why I wanted to
question this behaviour in
https://github.com/openstreetmap/openstreetmap-website/pull/7136#discussion_r3366022350
too.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7136#discussion_r3370094799
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7136/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
