@hlfan commented on this pull request.
> @@ -80,10 +76,13 @@ def wikipedia_links(key, value)
# Some k/v's are wikipedia=http://en.wikipedia.org/wiki/Full%20URL
return nil if %r{^https?://}.match?(value)
+ # regex to match all language codes from de to zh-classical
+ language_code_pattern = /[a-z]{1,2}[a-z-]{0,7}[a-z]{1,3}/
Can I just leave the expression as it was, only extracted?
```suggestion
language_code_pattern = /[a-z-]{2,12}/
```
at least not \S+...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7136#discussion_r3383024779
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7136/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
