@hlfan commented on this pull request.
> @@ -81,9 +77,9 @@ def wikipedia_links(key, value)
return nil if %r{^https?://}.match?(value)
case key
- when "wikipedia", /^(#{SECONDARY_WIKI_PREFIXES}):wikipedia/o
- lang = "en"
I'm just talking about wikipedia tags (key and value combinations) that don't
set any language, which requires the fallback to "en".
This way has been discouraged since 2010 afaict:
https://osm.wiki/w/index.php?title=Key:wikipedia&oldid=491783
I tried to make the shared meaning clearer by moving the special case down.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7136#discussion_r3402807620
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7136/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev