@pablobm commented on this pull request.
> @@ -81,9 +77,9 @@ def wikipedia_links(key, value)
return nil if %r{^https?://}.match?(value)
case key
- when "wikipedia", /^(#{SECONDARY_WIKI_PREFIXES}):wikipedia/o
- lang = "en"
OK, I see it now. The original version of the code, and your question,
suggested to me that language-less **keys** (eg: `wikipedia`,
`brand:wikipedia`) were legacy, when they are not (they used to be). After
looking at this a bit more, now I understand better that it's a **key+value**
thing. Your latest version of the PR communicates this better (to me at least).
I'm not great at using the various query tools available. Looking at
https://qlever.dev/osm-planet/PnNfKG it looks to me like there's only 1105
instances of this? No idea what thresholds we normally use, but to me it feels
like we can drop this case, if only to encourage people to convert these last
few ones.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7136#discussion_r3412930603
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7136/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
