@gravitystorm commented on this pull request.
See also inline comments.
I'd like to echo @tomhughes point about this not being our primary goal. If we
have settings that we are never going to change in production, then it's just
extra work for our developers. For example, when we are working on the user
profile page, we need to switch the setting on and off to see how both versions
look. Or even just reading the extra code, understanding why there's an if
statement, reading up on the background, etc.
On the other hand, while catering for alternative deployments isn't a priority
here, I'm keen to make sure we don't make life unnecessarily difficult for them.
If we start making more features toggleable, then we get a combinatorial
explosion of possibilities, and lots more complexity - again, which doesn't
directly benefit our primary goal.
We don't have a list of alternative deployments, but I would be interested in
knowing if this option would be used by other deployments in addition to
OpenGeofiction. It's not a vote, but the more useful a feature is then the more
it could be worth the downsides.
> @@ -108,6 +108,13 @@ def require_cookies
end
end
+ def check_gps_traces_enabled
Instead of having a helper and lots of before_actions, it might be cleaner just
to remove the routes in config/routes. That way, any requests will still return
a 404, without having the implementation scattered around.
> @@ -29,6 +29,8 @@ status: "online"
#status_announcement_url: "https://en.osm.town/@osm_tech";
# The maximum area you're allowed to request, in square degrees
max_request_area: 0.25
+# GPS traces/tracks feature - set to false to disable entirely
+gps_traces_enabled: true
I mentioned this in #7111 but the traces feature is not limited to GPS traces,
and so I think we should avoid mentioning GPS in the settings name.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7156#pullrequestreview-4525453866
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7156/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
