@wangi commented on this pull request.
> @@ -76,6 +76,7 @@
required(:api_version).filled(:str?)
required(:max_request_area).filled(:number?)
required(:max_note_request_area).filled(:number?)
+ required(:traces_enabled).filled(:bool?)
`settings.yml` provides the default so it's always present, and put `required`
here to cover it being missing in the yml (existing installs?)
I did also consider that the setting should be `traces_disabled`... no
`config.rb` change and the tests along the lines of `can [:read, :data], Trace
unless Settings.traces_disabled`. I wasn't a fan of the negative, but the test
is clean.
What do you think?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7156#discussion_r3477784013
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7156/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
