Sven, It's almost exactly similar, with one exception. I do a more duck-typing approach, checking for the method human_attribute_name, she checks if it is an AR-object and assumes it's there. I like my approach better, because one might want to implement translation on non activerecord classes too.
My original patch for reference: http://i18n.lighthouseapp.com/projects/14948/tickets/10-form-lael-should-use-i18n Iain On Fri, Sep 19, 2008 at 18:38, Sven Fuchs <[EMAIL PROTECTED]> wrote: > > Hey Iain, > > I've received a pull request from jana4u on github for this commit: > > http://github.com/jana4u/rails/commit/070e9eea4443c2629952e7891deb1038b1b90bd8 > > ... which deals with translating labels as well. > > I'm not sure what to do with it. Could you have a look at it? > > Thanks :) > > > On 17.09.2008, at 14:47, Iain Hecker wrote: > >> No, ActiveRecord also uses activerecord namespace. This was changed >> about a month ago. It was part of a cleanup action, because the >> activerecord scope got rather littered. >> >> I use the Rails mechanisms in the i18n_label plugin, so it can't be >> different :) >> >> Iain >> >> On Wed, Sep 17, 2008 at 14:42, pierre <[EMAIL PROTECTED]> wrote: >>> >>> Humm. >>> >>> In fact, the error was mine, but looks strange. >>> >>> You have to use >>> activerecord: >>> attributes: >>> user: >>> .... >>> >>> WHEREAS active record translation for rails uses >>> active_record: >>> .. >>> >>> This is kind of strange no ? >>> >>> Pierre >>> On Sep 17, 2:24 pm, "Iain Hecker" <[EMAIL PROTECTED]> wrote: >>>> The problem Piotr ran into was that he wasn't using an instance of >>>> AR >>>> in form_for. >>>> >>>> Wrong way is: form_for(:user) do |form| >>>> Right way is: form_for(@user) do |form| >>>> >>>> Were you using this as well? >>>> >>>> It works just fine with me... >>>> >>>> Iain >>>> >>>> On Wed, Sep 17, 2008 at 14:19, pierre <[EMAIL PROTECTED]> >>>> wrote: >>>> >>>>> I installed the plugin and add : >>>>> fr-FR: >>>>> active_record: >>>>> attributes: >>>>> user: >>>>> first_name: Prénom >>>>> last_name: Nom >>>>> birthday: Anniversaire >>>>> country: Pays >>>> >>>>> And then <%= f.label:first_name %> display : First name >>>> >>>>> Has anyone managed to get this plugin working ? >>>> >>>>> Thanks >>>>> Pierre >>>> >>>>> On Sep 16, 9:29 pm, "Yaroslav Markin" <[EMAIL PROTECTED]> >>>>> wrote: >>>>>> There's a plugin that didn't make Rails core >>>>>> yet:http://github.com/iain/i18n_label/ >>>> >>>>>> 2008/9/16 Piotr Hlawski <[EMAIL PROTECTED]> >>>> >>>>>>> I have an translation of my activerecord attributes and i >>>>>>> suppose that >>>>>>> labelmethod should work with it, but it didn't, i.e.: >>>> >>>>>> -- >>>>>> Yaroslav Markin >>>>>> evilmartians.com | rubyonrails.ru >>> >>>> >>> >> >> > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "rails-i18n" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rails-i18n?hl=en -~----------~----~----~----~------~----~------~--~---
