[
https://issues.apache.org/jira/browse/RAVE-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086290#comment-13086290
]
[email protected] commented on RAVE-148:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1528/#review1485
-----------------------------------------------------------
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/model/User.java
<https://reviews.apache.org/r/1528/#comment3396>
This may not be useful yet. We have not checked OpenID login with any
accounts other than the openID test account.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/model/User.java
<https://reviews.apache.org/r/1528/#comment3397>
Good to delete this method. Must test password reset with hashing and
salting
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/model/UserProfile.java
<https://reviews.apache.org/r/1528/#comment3398>
Do we need this separate class, or can we just use User?
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/model/UserProfile.java
<https://reviews.apache.org/r/1528/#comment3399>
Need to confirm that this works with password hashing and salting.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java
<https://reviews.apache.org/r/1528/#comment3416>
User "profile" here may be confused with OS Person. Profile here is
prescriptive metadata for the rave-portal DB only (username, password, layout,
etc).
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java
<https://reviews.apache.org/r/1528/#comment3415>
Widgets can be distributed other ways. This is the simplest but may not be
best from the user's point of view.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/web/controller/UserProfileController.java
<https://reviews.apache.org/r/1528/#comment3417>
Resolve this with the tabbed view now in SVN.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/web/controller/UserProfileController.java
<https://reviews.apache.org/r/1528/#comment3418>
Verify this works with hashed passwords.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/web/controller/UserProfileController.java
<https://reviews.apache.org/r/1528/#comment3419>
Obsolete comment.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/web/controller/UserProfileController.java
<https://reviews.apache.org/r/1528/#comment3420>
This is not the correct exception to throw. It occurs if you try to create
a new user with the same username as an existing user.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/web/validator/NewAccountValidator.java
<https://reviews.apache.org/r/1528/#comment3421>
"4" shouldn't be hard-coded. This should be in a property file.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/web/validator/UserProfileValidator.java
<https://reviews.apache.org/r/1528/#comment3422>
See recent updates to other validator classes. Make this validator
consistent with the others.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/resources/messages.properties
<https://reviews.apache.org/r/1528/#comment3423>
Should be "at least"
- Marlon
On 2011-08-16 18:14:22, Raminder Singh wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1528/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-16 18:14:22)
bq.
bq.
bq. Review request for rave, Raminder Singh and Jasha Joachimsthal.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Review RAVE 148 : Allow any logged in user to change his/her layout
bq.
bq.
bq. This addresses bug RAVE-148.
bq. https://issues.apache.org/jira/browse/RAVE-148
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/model/User.java
1154667
bq.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/model/UserProfile.java
PRE-CREATION
bq.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/service/PageService.java
1154667
bq.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/service/RegionService.java
1154667
bq.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/service/RegionWidgetService.java
1154667
bq.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/service/UserService.java
1154667
bq.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/service/impl/DefaultPageService.java
1154667
bq.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/service/impl/DefaultRegionService.java
1154667
bq.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/service/impl/DefaultRegionWidgetService.java
1154667
bq.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java
1154667
bq.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/web/controller/UserProfileController.java
1154667
bq.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/web/validator/NewAccountValidator.java
1154667
bq.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/portal/web/validator/UserProfileValidator.java
1154667
bq.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/resources/messages.properties
1154667
bq.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/webapp/WEB-INF/views/userProfile.jsp
1154667
bq.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/webapp/script/rave_forms.js
1154667
bq.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/test/java/org/apache/rave/portal/service/UserServiceTest.java
1154667
bq.
bq. Diff: https://reviews.apache.org/r/1528/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. No
bq.
bq.
bq. Thanks,
bq.
bq. Raminder
bq.
bq.
> Enable additional pagelayout styles in initial_data.sql, associate with demo
> accounts
> -------------------------------------------------------------------------------------
>
> Key: RAVE-148
> URL: https://issues.apache.org/jira/browse/RAVE-148
> Project: Rave
> Issue Type: Sub-task
> Reporter: Marlon Pierce
> Assignee: Matt Franklin
> Attachments: Rave-148(1).patch, Rave-148(2).patch, Rave-148-3.patch
>
>
> Several layouts are defined in initial_data.sql but are not currently
> supported. These need to be enabled. Also, there needs to be a way to
> smoothly go back and forth between different column layouts.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
