On 09/28/2011 11:35 PM, Franklin, Matthew B. wrote:
Dropped general@incubator from this discussion.

-----Original Message-----
From: Ate Douma [mailto:[email protected]]
Sent: Wednesday, September 14, 2011 4:49 AM
To: [email protected]
Cc: Upayavira; [email protected]
Subject: Re: Ping: [VOTE] Release Apache Rave 0.3-incubating

Hi Upayavira,

Thanks for reviewing.

I've feedback inline below.

On 09/14/2011 10:31 AM, Upayavira wrote:

<snip>

   2. This one is less of a deal - the convention is for artifacts to be
      named apache-$PROJECT-$BLAH, whereas this is rave-$BLAH. Could
      future
      releases be apache-rave-$BLAH?

Yes, I agree that would be better and we surely can do that for the next
release.

Note though, while this might be a good convention, I've seen numerous
(both
incubating and TLP) releases which have not adopted (yet) this.
Which I think is the explanation why Rave hasn't done it either. We were just
following some other projects examples.


Should we do this for maven repository artifacts as well as source and demo 
binaries?  Does anyone who has more familiarity with Maven want to take on 
renaming the artifacts to apache-rave-x?  If no one takes it on, I will do it 
before releasing on Friday.
IMO we only need do this for the source and demo binaries.
No other (Apache) project that I'm aware of uses the full apache- prefix for the maven repository artifacts, except those which produce OSGi bundles, and then they use qualified package naming, e.d. with dots instead of dashes.

The changes needed for this are trivial. It only needs overriding the default finalName configuration for the assembly plugin.

And if we then override the finalName anyway, I'd like to drop -project from the release artifact name as well.
Currently we produce rave-project-<version>-<source-release|bin> releases.
After the change: apache-rave-<version>-<source-release|bin> releases.

I can commit this, assuming lazy consensus, sometime tomorrow.

Ate

Reply via email to